Add upper limit of max window size and packet size, Add unit tests#995
Open
yosuke-wolfssl wants to merge 1 commit into
Open
Add upper limit of max window size and packet size, Add unit tests#995yosuke-wolfssl wants to merge 1 commit into
yosuke-wolfssl wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens wolfSSH_CTX_SetWindowPacketSize() by introducing compile-time upper bounds for accepted window and packet sizes, and adds a unit test to validate the new behavior.
Changes:
- Added
WINDOW_SZ_UPPER_BOUNDandMAX_PACKET_SZ_UPPER_BOUNDconstants. - Enforced the new upper bounds in
wolfSSH_CTX_SetWindowPacketSize(). - Added an API unit test covering defaulting behavior and boundary/overflow cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
wolfssh/internal.h |
Defines upper-bound macros for window and packet size accepted by wolfSSH_CTX_SetWindowPacketSize(). |
src/ssh.c |
Adds validation logic to reject window/packet sizes above the configured upper bounds. |
tests/api.c |
Adds a unit test for wolfSSH_CTX_SetWindowPacketSize() covering defaults and upper-bound checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yosuke-wolfssl
force-pushed
the
fix/f_5572
branch
from
ce95cf7 to
e752ae2
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #995
Scan targets checked: wolfssh-bugs, wolfssh-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
yosuke-wolfssl
force-pushed
the
fix/f_5572
branch
from
e752ae2 to
b56f291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds following things:
Addressed by f_5572